johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [johnzon] rmannibucau commented on a change in pull request #74: True object and array streaming
Date Sat, 10 Jul 2021 07:27:19 GMT

rmannibucau commented on a change in pull request #74:
URL: https://github.com/apache/johnzon/pull/74#discussion_r667304521



##########
File path: johnzon-core/src/main/java/org/apache/johnzon/core/JohnzonJsonParserImpl.java
##########
@@ -134,18 +140,57 @@ public void skipArray() {
 
     @Override
     public Stream<JsonValue> getArrayStream() {
-        //X TODO this implementation is very simplistic
-        //X I find it unintuitive what the spec intends here
-        //X we probably need to improve this
-        return getArray().stream();
+        Event current = current();
+        if (current != Event.START_ARRAY) {
+            throw new IllegalStateException(current + " doesn't support getArrayStream()");
+        }
+
+        Spliterator<JsonValue> arraySpliterator = new Spliterators.AbstractSpliterator<JsonValue>(

Review comment:
       if you think you need 2 inner classes it is fine for me too, what I want to ensure
is that it is not referencing $0 (this).
   it is also fine ot inject the impl of tryAdvance as a lambda (the compiler will make it
right normally) so maybe something along:
   
   > new SimpleSplitIterator(action -> {  Event next = next(); ..... });
   
   this enables to factorize the config and avoids the $0 ref.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message