karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Freeman Fang <freeman.f...@gmail.com>
Subject Re: Clean up karaf-maven-plugin goals
Date Fri, 17 Apr 2015 03:30:41 GMT
+1 for first set of names.

Thanks
-------------
Freeman(Yue) Fang

Red Hat, Inc. 
FuseSource is now part of Red Hat



On 2015-4-16, at 下午10:49, Guillaume Nodet wrote:

> I created KARAF-3671 for this discussion.
> 
> I'm proposing the following:
>  * remove features-add-to-repository goal
>  * remove the features-validate-descriptor
>  * rename install-kars goal to *assembly*
>  * rename instance-create-archive to *archive*
>  * rename verify-features to *verify*
>  * rename  features-create-kar to *kar*
> 
> The other goals are:
>  * features-export-meta-data
>  * features-generate-descriptor
>  * commands-generate-help
> and we'd have to find names more
> 
> I'm not really sure the features-generate-descriptor is widely used.  Is it
> ?
> 
> For the naming, another option is to keep the [resource]-[action] idiom:
>  * assembly-create
>  * assembly-archive
>  * kar-create
>  * commands-generate-help
>  * features-verify
>  * features-generate-descriptor
>  * features-export-meta-data
> 
> The first option seems more inline with usual maven plugins, and they look
> nicer to me, but I don't really mind.
> Thoughts ?
> 
> 
> 2015-04-08 12:44 GMT+02:00 Guillaume Nodet <gnodet@apache.org>:
> 
>> In master, the karat-maven-plugin contains the following goals:
>> * features-add-to-repository
>> * features-create-kar
>> * features-export-meta-data
>> * features-generate-descriptor
>> * install-kars
>> * features-validate-descriptor
>> * verify-features
>> 
>> The features-add-to-repository mojo seems somewhat redundant with the
>> install-kars mojo which is used to build our own distribution.  The
>> features-export-meta-data seems redundant with the
>> features-generate-descriptor, and the features-validate-descriptor seems
>> redundant with the verify-features goal.
>> 
>> Am I missing something, or should we get rid of the
>> features-add-to-repository, features-export-meta-data and
>> features-generate-descriptor goals for 4.0 ?
>> 
>> Cheers,
>> Guillaume
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message