karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard Kaufhold (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-3103) config:edit does not correctly handle configuration visibility for --factory calls.
Date Mon, 07 Jul 2014 17:00:38 GMT

    [ https://issues.apache.org/jira/browse/KARAF-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053861#comment-14053861
] 

Richard Kaufhold commented on KARAF-3103:
-----------------------------------------

The patched version gives the expected output:

2014-07-07 18:57:41,920 | WARN  | 40-f567a6c34348) | HelloManagedServiceFactory       | 65
- de.ansii.example.hellofactory - 0.0.3.SNAPSHOT | Hello Managed PID de.ansii.example.hellofactory.f3b627b3-d304-49a6-b340-f567a6c34348:
{service.pid=de.ansii.example.hellofactory.f3b627b3-d304-49a6-b340-f567a6c34348, prop1=value1,
service.factorypid=de.ansii.example.hellofactory}


> config:edit does not correctly handle configuration visibility for --factory calls.
> -----------------------------------------------------------------------------------
>
>                 Key: KARAF-3103
>                 URL: https://issues.apache.org/jira/browse/KARAF-3103
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-config
>    Affects Versions: 4.0.0, 3.0.2
>            Reporter: Richard Kaufhold
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The ConfigRepositoryImpl does not specify the visibility for created configurations.
I have tested it using my own ManagedServiceFactory:
> Inside of the karaf shell I executed:
> karaf@root()> config:edit --factory de.ansii.example.hellofactory
> karaf@root()> config:property-append prop1 value1
> karaf@root()> config:update
> The response was:
> 2014-07-07 15:18:45,038 | ERROR | 04-24cc6aa84094) | configadmin                    
 | 5 - org.apache.felix.configadmin - 1.6.0 | Cannot use configuration de.ansii.example.hellofactory.5b076892-5207-4913-a704-24cc6aa84094
for [org.osgi.service.cm.ManagedServiceFactory, id=90, bundle=65/mvn:de.ansii.example/hellofactory]:
No visibility to configuration bound to mvn:org.apache.karaf.config/org.apache.karaf.config.core/4.0.0-SNAPSHOT
> In line 91 of /org.apache.karaf.config.core/src/main/java/org/apache/karaf/config/core/impl/ConfigRepositoryImpl.java
you missed to specify the visibility. (null is a sensible default, as in line 44)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message