karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-4986) A condition that is always true.
Date Mon, 24 Apr 2017 12:17:04 GMT

    [ https://issues.apache.org/jira/browse/KARAF-4986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981072#comment-15981072
] 

ASF subversion and git services commented on KARAF-4986:
--------------------------------------------------------

Commit 33f8eb3cde781fe74d60ff241eb89bbcc4ab5954 in karaf-cellar's branch refs/heads/master
from [~jbonofre]
[ https://git-wip-us.apache.org/repos/asf?p=karaf-cellar.git;h=33f8eb3 ]

[KARAF-4986] Fix remove features repository issue


> A condition that is always true.
> --------------------------------
>
>                 Key: KARAF-4986
>                 URL: https://issues.apache.org/jira/browse/KARAF-4986
>             Project: Karaf
>          Issue Type: Bug
>          Components: cellar-features
>            Reporter: JC
>            Assignee: Jean-Baptiste Onofré
>            Priority: Trivial
>             Fix For: cellar-4.0.4, cellar-4.1.0
>
>
> I've found code smells and typos in a recent github snapshot. (karaf-cellar)
> Path: features/src/main/java/org/apache/karaf/cellar/features/management/internal/CellarFeaturesMBeanImpl.java
> {code:java}
> 559             for (String url : urls) {
> 560                 // looking for the URL in the list
> 561                 boolean found = false;
> 562                 for (String repository : clusterRepositories.keySet()) {
> 563                     if (repository.equals(repository)) {
> 564                         found = true;
> 565                         break;
> 566                     }
> 567                 }
> 568                 if (found) {
> 569                     Features repositoryModel = JaxbUtil.unmarshal(url, true);
> {code}
> The line 563 should be like this?
> {code:java}
> 563                     if (repository.equals(url)) {
> {code}
> There is a similar issue in the following path as well: features/src/main/java/org/apache/karaf/cellar/features/shell/RepoRemoveCommand.java
> {code:java}
> 116             for (String url : urls) {
> 117                 // looking for the URL in the list
> 118                 boolean found = false;
> 119                 for (String repository : clusterRepositories.keySet()) {
> 120                     if (repository.equals(repository)) {
> 121                         found = true;
> 122                         break;
> 123                     }
> {code}
> This might be trivial issues but wanted to report just in case.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message