libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From allardhoeve <...@git.apache.org>
Subject [GitHub] libcloud pull request: Create volume from snapshot on EC2 and OS
Date Tue, 24 Feb 2015 13:25:00 GMT
GitHub user allardhoeve opened a pull request:

    https://github.com/apache/libcloud/pull/467

    Create volume from snapshot on EC2 and OS

    Both platforms support creating a volume from snapshots but do not implement it.
    
    Please see individual commit messages for reasoning on why the changes are as they are.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ByteInternet/libcloud create-volume-from-snapshot

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/467.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #467
    
----
commit a60d03c71075981a024705561e733b1b002d1f2b
Author: Allard Hoeve <allard@byte.nl>
Date:   2015-02-24T12:47:00Z

    Implement creating volumes from EC2 snapshots
    
    LIBCLOUD-672 #close

commit f3a41a156ad8aa41b647c0d1d7954862b5490579
Author: Allard Hoeve <allard@byte.nl>
Date:   2015-02-24T12:50:42Z

    Implement creating volumes from OpenStack snapshots
    
    LIBCLOUD-673 #close

commit 163d097be900af793959c26d96eabae3aa374832
Author: Allard Hoeve <allard@byte.nl>
Date:   2015-02-24T12:54:36Z

    Change signature of base class (see comment)
    
    The base driver defines a signature that is not used by any of the drivers implementing
`create_volume`.
    
    1. `gandi` does not use the snapshot parameter.
    1. `gce` uses the parameter, but accepts either a string or an object or None.
    1. `ibm` does not use the snapshot parameter.
    1. `opennebula` does not use the snapshot parameter.
    1. `profitbricks` breaks the contract entirely.
    
    In this PR both `ec2` and `openstack` implement the signature like this. This matches
`gce`, so all drivers using the snapshot functionality act like this new signature.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message