libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-749) CloudStack: bugs in the method ex_authorize_security_group_ingress
Date Sun, 11 Oct 2015 14:11:05 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952297#comment-14952297
] 

ASF subversion and git services commented on LIBCLOUD-749:
----------------------------------------------------------

Commit a35bc7e536edc2f2c7c54d8f001d557029170562 in libcloud's branch refs/heads/trunk from
lionel
[ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=a35bc7e ]

[LIBCLOUD-749] Fixed a minor issue with the docstring of the method ex_authorize_security_group_ingress

Closes #580

Signed-off-by: Tomaz Muraus <tomaz@apache.org>


> CloudStack: bugs in the method ex_authorize_security_group_ingress
> ------------------------------------------------------------------
>
>                 Key: LIBCLOUD-749
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-749
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>         Environment: CloudStack compute driver
>            Reporter: L. Schaub
>              Labels: Bug, CloudStack, Improvement, SecurityGroups
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The method ex_authorize_security_group_ingress contains some bugs:
> - The docstring doesn't match parameters of the method.
> - Only ICMP and TCP is allowed even if the doc of the parameter "protocol" mention TCP
and UDP.
> - Moreover ICMP cannot be used because there is no way to specify the two required parameters
"icmptype" and "icmpcode".
> - The parameter endport is not used if it's defined.
> - The return type is not a list but a dict.
> - The unit test doesn't use parameters in the correct order.
> So I created a patch which aims to fix these bugs and also try to do the following:
> - Improve the docstring to be a bit more detailed (the previous one comes from the official
Apache CloudStack documentation).
> - Add a kwargs to allow to provide extra parameters defined in the API and in the docstring.
> - Improve the unit test.
> - Add support for other protocols like AH, GRE, ESP which are available on some Cloud
like Exoscale.
> I will provide the patch as a Pull Request in GitHub.
> Regards



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message