libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From allardhoeve <...@git.apache.org>
Subject [GitHub] libcloud pull request: Turn all States into string values instead ...
Date Tue, 03 Nov 2015 11:17:34 GMT
GitHub user allardhoeve opened a pull request:

    https://github.com/apache/libcloud/pull/624

    Turn all States into string values instead of ints

    @Kami
    
    Luckily, most tests already used the constants. I found a couple sloppy drivers, especially
the ProfitBricks driver, which uses NodeState for everything, including Volumes and Snapshots.
Maybe we fix that, maybe we leave it. It doesn't really matter.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ByteInternet/libcloud all-states-are-string

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #624
    
----
commit 6c46708c68defbcb73cea552ab6be9c8a2a0bcb4
Author: Allard Hoeve <allard@byte.nl>
Date:   2015-11-03T11:12:34Z

    Turn NodeState into string

commit 6518c9258cb0df16629edd612cf32aaf13683e6e
Author: Allard Hoeve <allard@byte.nl>
Date:   2015-11-03T11:14:54Z

    Turn VolumeSnapshotState into string

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message