libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tonybaloney <>
Subject [GitHub] libcloud pull request #1015: [WIP] Fix CertificateConnection in >2.0Rc1
Date Sun, 02 Apr 2017 00:36:50 GMT
GitHub user tonybaloney opened a pull request:

    [WIP] Fix CertificateConnection in >2.0Rc1

    ## Reimplement the CertificateConnection class using urllib3 and requests
    ### Description
    In 2.0, the httplib module was used as a low-level module for making requests to the APIs,
some drivers used a `CertificateConnection` class in `libcloud.common.base`, which accepted
an x509 certificate to be used for encoding the requests.
    Those drivers are : 
    - Azure (classic)
    - Docker (with TLS)
    - OpenStack
    This PR will reimplement the CertificateConnection class inside `libcloud.httplib_ssl`
by mounting a `HTTPAdapter` to the requests session, detecting TLS and signing requests for
the cert file.
    We also need a test for this issue.
    ### Status
    Replace this: describe the PR status. Examples:
    - work in progress
    - done, ready for review
    ### Checklist (tick everything that applies)
    - [ ] [Code linting](
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](
    - [ ] [ICLA](
(required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull certificate_connection_fix

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1015
commit 64e0b3c9fb7693747c2078adf9c1c3b47b6065e1
Author: Anthony Shaw <>
Date:   2017-04-02T00:32:49Z

    start building signed request adapter for the requests package


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message