libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ldipenti <...@git.apache.org>
Subject [GitHub] libcloud pull request #1120: On Azure ARM, destroy_node() do VHD cleanup eve...
Date Wed, 04 Oct 2017 17:19:09 GMT
GitHub user ldipenti opened a pull request:

    https://github.com/apache/libcloud/pull/1120

    On Azure ARM, destroy_node() do VHD cleanup even when NIC cleanup fails

    ### Description
    
    When calling destroy_node() on Azure ARM, several cloud calls happen. After successfully
destroying the VM, the method tries to remove all NICs related to that VM. If one of these
attempts fail, the VHD's life is spared.
    The updates on this PR make destroy_node() continue with its task after a NIC cleanup
fail, trying to remove the remaining NICs and the assigned VHD.
    Also added tests for destroy_node(), modified the test suite a little to be able to simulate
different HTTP response sequences.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [X] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/curoverse/libcloud azurearm-destroy-node-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1120
    
----
commit 04eca2ffbafe4ce1ae88b49a0a838169ab499964
Author: Lucas Di Pentima <ldipentima@veritasgenetics.com>
Date:   2017-10-03T23:20:23Z

    On Azure ARM, fix destroy_node() return value when successfully
    destroying a node but the NIC failed to be cleaned up.
    Added missing tests.

----


---

Mime
View raw message