libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tetron <...@git.apache.org>
Subject [GitHub] libcloud pull request #1128: Fix api version used to list and delete NICs.
Date Wed, 11 Oct 2017 14:54:50 GMT
GitHub user tetron opened a pull request:

    https://github.com/apache/libcloud/pull/1128

    Fix api version used to list and delete NICs.

    ## Fix api version used to list and delete NICs.
    
    ### Description
    
    Adds ex_destroy_nic.
    
    Also adjust codes to reflect that Azure returns 204 when attempting to destroy
    a resource that doesn't exist.
    
    ### Status
    
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/curoverse/libcloud fix_nic_delete

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1128
    
----
commit 61cdd12652477094468eddd44bf8cfe7b30f82ac
Author: Peter Amstutz <peter.amstutz@curoverse.com>
Date:   2017-10-11T14:24:43Z

    Add ex_destroy_nic.  Fix api version used to list and delete NICs.
    
    Also adjust codes to reflect that Azure returns 204 when attempting to destroy
    a resource that doesn't exist.

----


---

Mime
View raw message