libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tetron <...@git.apache.org>
Subject [GitHub] libcloud pull request #1137: Azure ARM fix delete_old_vhd
Date Wed, 18 Oct 2017 20:23:50 GMT
GitHub user tetron opened a pull request:

    https://github.com/apache/libcloud/pull/1137

    Azure ARM fix delete_old_vhd

    Azure ARM fix delete_old_vhd
    
    ### Description
    
    Fix delete_old_vhd:
    
    * Returns "False" on failure instead of raising an exception (which was what it had expected)
so now checks the return code
    * Fix longstanding bug in AzureConnection for non-GET requests that don't include a Content-Length
header (affects delete_object()).
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/curoverse/libcloud arm-destroy-old-vhd

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1137
    
----
commit 9884ed59a2ada4ed0f24c23b04c29b3f40f5216e
Author: Peter Amstutz <peter.amstutz@curoverse.com>
Date:   2017-10-18T15:31:26Z

    Retry _ex_delete_old_vhd when it returns False.

commit 1320bbda94e082ae90778833d0d14a387d3b7cb0
Author: Peter Amstutz <tetron@manage.c97qk.arvadosapi.com>
Date:   2017-10-18T20:15:16Z

    Fix bug in Azure blob store request signing preventing delete_object() from working.

----


---

Mime
View raw message