libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdloo <...@git.apache.org>
Subject [GitHub] libcloud pull request #1177: Implement floating ips digitalocean
Date Sun, 04 Mar 2018 21:46:20 GMT
GitHub user vdloo opened a pull request:

    https://github.com/apache/libcloud/pull/1177

    Implement floating ips digitalocean

    Implement ex_create_floating_ip, ex_delete_floating_ip, ex_list_floating_ips and ex_get_floating_ip
for the DigitalOcean compute driver 
    
    See https://developers.digitalocean.com/documentation/v2/#floating-ips

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vdloo/libcloud implement-floating-ips-digitalocean

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1177
    
----
commit 13f9217a79a20ff9b76de00d0784900489a5b6ab
Author: Rick van de Loo <rickvandeloo@...>
Date:   2018-03-04T13:15:23Z

    implement ex_create_floating_ip for DigitalOcean
    
    create a new unassociated floating IP in a region

commit 3416df600d134f2aeb6178660525132f24d01496
Author: Rick van de Loo <rickvandeloo@...>
Date:   2018-03-04T13:26:25Z

    implement ex_delete_floating_ip for DigitalOcean
    
    delete a floating IP by passing the object into conn.ex_delete_floating_ip
    or by running .delete on the floating IP object

commit f3d517f8e78ab85e6d3ad522492631f5514d324b
Author: Rick van de Loo <rickvandeloo@...>
Date:   2018-03-04T13:33:07Z

    implement ex_list_floating_ips for DigitalOcean

commit da8eaebf95441d8485b9ef32a75fa6ba6c9dfd7f
Author: Rick van de Loo <rickvandeloo@...>
Date:   2018-03-04T13:44:54Z

    implement ex_get_floating_ip for DigitalOcean
    
    Throws ValueError if the IP can not be found.
    
    Inspired by ex_get_floating_ip from openstack.py,
    but that one does `ip_obj, = [x for x in floating_ips if x.ip_address == ip]`
    which will cause an ugly unpacking error if the IP can not be found:
    `ValueError: need more than 0 values to unpack`

----


---

Mime
View raw message