libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bverschueren <...@git.apache.org>
Subject [GitHub] libcloud pull request #1214: [LIBCLOUD-996] Support GCP service_account auth...
Date Wed, 23 May 2018 19:59:01 GMT
GitHub user bverschueren opened a pull request:

    https://github.com/apache/libcloud/pull/1214

    [LIBCLOUD-996] Support GCP service_account authentication from JSON obj/str

    ## Support GCP service_account authentication from JSON obj/str
    
    ### Description
    
    
    Currently GCP service_account authentication credentials can be provided using the JSON/PEM
file acquired from GCP console or gcloud utility. It would be convenient if the JSON content
could be directly provided as an object or serialized JSON string to eliminate the need of
having the file locally on the calling host.
    
    In this PR:
    - add logic to support JSON dict and str handling
    - rearrange PEM/JSON related GCE_PARAMS_* constant names in test_google.py for better
clarity
    - add tests for JSON content as a dict and as a str
    
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bverschueren/libcloud LIBCLOUD-996_gcp_svc_acct_credentials_from_json

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1214
    
----
commit 409d428eed31b017c74c9b34378a3817b55398df
Author: Bram Verschueren <verschueren.bram@...>
Date:   2018-05-09T13:56:29Z

    add support for retrieving private key from JSON object/string/file

----


---

Mime
View raw message