libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] vdloo commented on pull request #1467: Fix OpenStack image v2 pagination handling
Date Fri, 12 Jun 2020 10:55:17 GMT

vdloo commented on pull request #1467:
URL: https://github.com/apache/libcloud/pull/1467#issuecomment-643209361


   cool, looks good to me :+1:
   
   before:
   ```
   In [5]: conn.list_images()
   Out[5]: 
   [<NodeImage: id=44864339-18a3-445f-bf91-1398e0ad4d32, name=image1000, driver=OpenStack
 ...>,
    <NodeImage: id=e1ad28c3-8770-439a-9120-6261bdbc8ad6, name=image999, driver=OpenStack
 ...>,
    <NodeImage: id=d6d02d2b-89c7-4c22-b03d-5990469e15d0, name=image998, driver=OpenStack
 ...>,
    <NodeImage: id=8b6de47f-59be-4c61-86cf-c5366b9d65c3, name=image997, driver=OpenStack
 ...>,
    <NodeImage: id=ccbd11f0-025b-4b9d-b9af-8f3d9729a5bb, name=image996, driver=OpenStack
 ...>,
    <NodeImage: id=30cc7e45-ecaa-46de-a852-44674899f392, name=image995, driver=OpenStack
 ...>,
    <NodeImage: id=962dbfe1-3cf6-4779-81a4-1ff053adb554, name=image994, driver=OpenStack
 ...>,
    <NodeImage: id=c6d6331e-e91f-4e69-a773-4a35345124a9, name=image993, driver=OpenStack
 ...>,
    <NodeImage: id=8bcd3aaf-03e9-4811-9761-3eea1c17796d, name=image992, driver=OpenStack
 ...>,
    <NodeImage: id=b81b9757-590a-44d2-b60e-7661a1e8f8dc, name=image991, driver=OpenStack
 ...>,
    <NodeImage: id=d98c6664-b3dc-44b3-9829-a26324e7d02b, name=image990, driver=OpenStack
 ...>,
    <NodeImage: id=035406b9-7e84-4ca8-a427-eefe29fa45a0, name=image989, driver=OpenStack
 ...>,
    <NodeImage: id=641d061c-9891-4211-81b2-02396979eb40, name=image988, driver=OpenStack
 ...>,
    <NodeImage: id=58e43728-813e-4353-9504-84b1aa8bd91d, name=image987, driver=OpenStack
 ...>,
    <NodeImage: id=a0c78610-6fea-4638-b95e-10cea6968853, name=image986, driver=OpenStack
 ...>,
    <NodeImage: id=c5dc07a4-3c2f-4444-8c3e-b8cff9f0bc22, name=image985, driver=OpenStack
 ...>,
    <NodeImage: id=e1880ebf-4940-4d65-b31e-fa0b4d66e939, name=image984, driver=OpenStack
 ...>,
    <NodeImage: id=32686def-0a8c-47cf-9609-68740f27b475, name=image983, driver=OpenStack
 ...>,
    <NodeImage: id=99c0aa14-5bd1-45bc-b5ae-ec024c3e74b4, name=image982, driver=OpenStack
 ...>,
    <NodeImage: id=ad328d5d-7743-43fc-ac41-db1fa57edf8a, name=image981, driver=OpenStack
 ...>,
    <NodeImage: id=4d1bc2bd-098d-49e2-8a05-f622c74e9332, name=image980, driver=OpenStack
 ...>,
    <NodeImage: id=51428528-676a-4403-a013-1979111d090f, name=image979, driver=OpenStack
 ...>,
    <NodeImage: id=d82e3e3a-1f40-4dca-9a48-a6bf37d07669, name=image978, driver=OpenStack
 ...>,
    <NodeImage: id=6d7ce1c0-2200-49b9-8e6d-ed8db80378ba, name=image977, driver=OpenStack
 ...>,
    <NodeImage: id=e419dc3f-6989-46b8-87c2-bf930722ccb9, name=image976, driver=OpenStack
 ...>]
   
   In [6]: len(conn.list_images())
   Out[6]: 25
   ```
   
   after:
   ```
   In [2]: conn.list_images()
   Out[2]:
   [<NodeImage: id=44864339-18a3-445f-bf91-1398e0ad4d32, name=image1000, driver=OpenStack
 ...>,
    <NodeImage: id=e1ad28c3-8770-439a-9120-6261bdbc8ad6, name=image999, driver=OpenStack
 ...>,
    <NodeImage: id=d6d02d2b-89c7-4c22-b03d-5990469e15d0, name=image998, driver=OpenStack
 ...>,
    <NodeImage: id=8b6de47f-59be-4c61-86cf-c5366b9d65c3, name=image997, driver=OpenStack
 ...>,
    <NodeImage: id=ccbd11f0-025b-4b9d-b9af-8f3d9729a5bb, name=image996, driver=OpenStack
 ...>,
    <NodeImage: id=30cc7e45-ecaa-46de-a852-44674899f392, name=image995, driver=OpenStack
 ...>,
    <NodeImage: id=962dbfe1-3cf6-4779-81a4-1ff053adb554, name=image994, driver=OpenStack
 ...>,
    <NodeImage: id=c6d6331e-e91f-4e69-a773-4a35345124a9, name=image993, driver=OpenStack
 ...>,
    <NodeImage: id=8bcd3aaf-03e9-4811-9761-3eea1c17796d, name=image992, driver=OpenStack
 ...>,
    <NodeImage: id=b81b9757-590a-44d2-b60e-7661a1e8f8dc, name=image991, driver=OpenStack
 ...>,
    <NodeImage: id=d98c6664-b3dc-44b3-9829-a26324e7d02b, name=image990, driver=OpenStack
 ...>,
    <NodeImage: id=035406b9-7e84-4ca8-a427-eefe29fa45a0, name=image989, driver=OpenStack
 ...>,
    <NodeImage: id=641d061c-9891-4211-81b2-02396979eb40, name=image988, driver=OpenStack
 ...>,
    <NodeImage: id=58e43728-813e-4353-9504-84b1aa8bd91d, name=image987, driver=OpenStack
 ...>,
    <NodeImage: id=a0c78610-6fea-4638-b95e-10cea6968853, name=image986, driver=OpenStack
 ...>,
    <NodeImage: id=c5dc07a4-3c2f-4444-8c3e-b8cff9f0bc22, name=image985, driver=OpenStack
 ...>,
    <NodeImage: id=e1880ebf-4940-4d65-b31e-fa0b4d66e939, name=image984, driver=OpenStack
 ...>,
    <NodeImage: id=32686def-0a8c-47cf-9609-68740f27b475, name=image983, driver=OpenStack
 ...>,
    <NodeImage: id=99c0aa14-5bd1-45bc-b5ae-ec024c3e74b4, name=image982, driver=OpenStack
 ...>,
    <NodeImage: id=ad328d5d-7743-43fc-ac41-db1fa57edf8a, name=image981, driver=OpenStack
 ...>,
    <NodeImage: id=4d1bc2bd-098d-49e2-8a05-f622c74e9332, name=image980, driver=OpenStack
 ...>,
    <NodeImage: id=51428528-676a-4403-a013-1979111d090f, name=image979, driver=OpenStack
 ...>,
    <NodeImage: id=d82e3e3a-1f40-4dca-9a48-a6bf37d07669, name=image978, driver=OpenStack
 ...>,
    <NodeImage: id=6d7ce1c0-2200-49b9-8e6d-ed8db80378ba, name=image977, driver=OpenStack
 ...>,
    <NodeImage: id=e419dc3f-6989-46b8-87c2-bf930722ccb9, name=image976, driver=OpenStack
 ...>,
    <NodeImage: id=2a37409b-bdee-41ff-b564-4ca4e795a7d4, name=image975, driver=OpenStack
 ...>,
   ...
   In [3]: len(conn.list_images())
   Out[3]: 1060
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message