libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] vdloo commented on a change in pull request #1467: Fix OpenStack image v2 pagination handling
Date Fri, 12 Jun 2020 14:23:08 GMT

vdloo commented on a change in pull request #1467:
URL: https://github.com/apache/libcloud/pull/1467#discussion_r439449943



##########
File path: libcloud/compute/drivers/openstack.py
##########
@@ -2862,10 +2862,14 @@ def list_images(self, location=None, ex_only_active=True):
             raise NotImplementedError(
                 "ex_only_active in list_images is not implemented "
                 "in the OpenStack_2_NodeDriver")
-        response = self.image_connection.request('/v2/images')
         images = []
-        for image in response.object['images']:
-            images.append(self._to_image(image))
+        path = '/v2/images'
+        while path:

Review comment:
       @toabctl do you want to give implementing this in terms of _paginated_request a try
and also add a line to CHANGES.rst for this change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message