libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1492: Fix error setting ex_force_xxx_url without setting ex_force_base_url
Date Tue, 22 Sep 2020 09:14:45 GMT

Kami commented on a change in pull request #1492:
URL: https://github.com/apache/libcloud/pull/1492#discussion_r492587833



##########
File path: libcloud/compute/drivers/openstack.py
##########
@@ -2841,6 +2841,9 @@ def __init__(self, *args, **kwargs):
         self._ex_force_base_url = original_ex_force_base_url
         if original_ex_force_base_url:
             kwargs['ex_force_base_url'] = self._ex_force_base_url
+        # if ex_force_base_url is not set in original params delete it
+        elif 'ex_force_base_url' in kwargs:

Review comment:
       LGTM, but can you please also add a test case for it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message