libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] displague edited a comment on pull request #1511: Packet rebranding to Equinix Metal
Date Thu, 22 Oct 2020 13:06:16 GMT

displague edited a comment on pull request #1511:
URL: https://github.com/apache/libcloud/pull/1511#issuecomment-714479333


   This looks good to me, if the preference is to leave a deprecated Packet driver in place,
the old Packet drivers could take on the new API endpoints and continue working until the
deprecation deadline is met.  There would be a minor change in the API results because the
`href` values have changed.
   
   I see more "Packet" references leftover in the code and documentation (`git grep -n -i
packet`), there are also more "packet.net", "packet.com", "packethost.net", and "net.packet"
references.  It's a tricky rename because TCP "packet" appears in several locations of the
code.
   
   The image `docs/_static/images/provider_logos/packet.png` should be updated to an Equinix
Metal name and logo (`find . -name \*packet\*`).
   
   Also, `libcloud/test/compute/test_equinixmetal.py` has two incorrect email address in the
comment block.  The maintainer should be updated and the credit to jed@packet.com (@jedsmith)
should be jed@linode.com (which isn't a current email address either).  This portion of the
comment block can probably be removed.
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message