libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] sergerdn opened a new pull request #1506: allow vultr.list_nodes to return extra values
Date Thu, 15 Oct 2020 04:49:45 GMT

sergerdn opened a new pull request #1506:
URL: https://github.com/apache/libcloud/pull/1506


   ### Description
   
   - update some fixtures to the current response of Vultr
   -  add missing `Node.private_ips`
   - allow `list_nodes` to return extra values:
   ```json
   {
      "ram":"1024 MB",
      "disk":"Virtual 25 GB",
      "vcpu_count":"1",
      "location":"Amsterdam",
      "DCID":"7",
      "default_password":"h6*hrte6tg",
      "pending_charges":"0.18",
      "cost_per_month":"5.00",
      "current_bandwidth_gb":0.026,
      "allowed_bandwidth_gb":"1000",
      "netmask_v4":"255.255.254.0",
      "gateway_v4":"45.76.42.1",
      "power_status":"running",
      "server_state":"installingbooting",
      "VPSPLANID":"201",
      "v6_networks":[
         {
            "v6_main_ip":"2001:19f0:5001:2b9c:5400:03ff:fe03:9568",
            "v6_network_size":"64",
            "v6_network":"2001:19f0:5001:2b9c::"
         }
      ],
      "kvm_url":"https://my.vultr.com/subs/novnc/api.php?data=erewawxFVZw2mXnhGUV",
      "auto_backups":"yes",
      "tag":"Web",
      "OSID":"387",
      "APPID":"0",
      "FIREWALLGROUPID":"0"
   }
   ```
   - I'v have improving tests too
   - add TODO for future work. Because I have a many plans for improving Vultr driver if this
PR will be accepted. 
   - fix a few lint errors
   
   ### Status
   - work in progress
   
   
   ### Checklist (tick everything that applies)
   
   - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
   - [ ] Documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
   This is my first PR, therefore any suggestions would be greatly appreciated.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message