logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From c...@apache.org
Subject cvs commit: logging-log4j/src/java/org/apache/log4j/db DBHelper.java
Date Tue, 04 Jan 2005 12:33:01 GMT
ceki        2005/01/04 04:33:01

  Modified:    src/java/org/apache/log4j/db DBHelper.java
  Log:
  Removing superflous log statement as static utility classes should not log without an explicit
repository reference.
  
  Revision  Changes    Path
  1.6       +2 -2      logging-log4j/src/java/org/apache/log4j/db/DBHelper.java
  
  Index: DBHelper.java
  ===================================================================
  RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/db/DBHelper.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- DBHelper.java	19 Nov 2004 14:50:51 -0000	1.5
  +++ DBHelper.java	4 Jan 2005 12:33:01 -0000	1.6
  @@ -21,7 +21,6 @@
   import java.sql.Statement;
   import java.util.Set;
   
  -import org.apache.log4j.LogManager;
   import org.apache.log4j.spi.LoggingEvent;
   
   /**
  @@ -51,7 +50,8 @@
         try { 
           connection.close();
         } catch(SQLException sqle) {
  -        LogManager.getLogger(DBHelper.class).warn("Failed to close connection.");
  +        // static utility classes should not log without an explicit repository
  +        // reference
         }
       }
     }
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message