logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claudio Corsi <cco...@progress.com>
Subject Re: svn commit: r439177 - in /logging/log4j/trunk/src/java/org/apache/log4j: scheduler/Scheduler.java spi/LocationInfo.java
Date Fri, 01 Sep 2006 14:50:26 GMT
Curt,

I've read that using notifyAll compared to notify causes a performance 
degradation. Have you run any performance tests comparing this change?

--Claudio

carnold@apache.org wrote:
> Author: carnold
> Date: Thu Aug 31 21:50:45 2006
> New Revision: 439177
> 
> URL: http://svn.apache.org/viewvc?rev=439177&view=rev
> Log:
> Bug 34762: Scheduler uses notify not notifyAll
> 
> Modified:
>     logging/log4j/trunk/src/java/org/apache/log4j/scheduler/Scheduler.java
>     logging/log4j/trunk/src/java/org/apache/log4j/spi/LocationInfo.java
> 
> Modified: logging/log4j/trunk/src/java/org/apache/log4j/scheduler/Scheduler.java
> URL: http://svn.apache.org/viewvc/logging/log4j/trunk/src/java/org/apache/log4j/scheduler/Scheduler.java?rev=439177&r1=439176&r2=439177&view=diff
> ==============================================================================
> --- logging/log4j/trunk/src/java/org/apache/log4j/scheduler/Scheduler.java (original)
> +++ logging/log4j/trunk/src/java/org/apache/log4j/scheduler/Scheduler.java Thu Aug 31
21:50:45 2006
> @@ -82,7 +82,7 @@
>        // if the job is the first on the list, then notify the scheduler thread
>        // to schedule a new job
>        if(i == 0) {
> -        this.notify();
> +        this.notifyAll();
>        }
>        return true;
>      } else {
> @@ -154,11 +154,11 @@
>      jobList.add(i, newSJE);
>      // if the jobList was empty, then notify the scheduler thread
>      if(i == 0) {
> -      this.notify();
> +      this.notifyAll();
>      }
>    }
>    
> -  public void shutdown() {
> +  public synchronized void shutdown() {
>      shutdown = true;
>    }
>    
> 
> Modified: logging/log4j/trunk/src/java/org/apache/log4j/spi/LocationInfo.java
> URL: http://svn.apache.org/viewvc/logging/log4j/trunk/src/java/org/apache/log4j/spi/LocationInfo.java?rev=439177&r1=439176&r2=439177&view=diff
> ==============================================================================
> --- logging/log4j/trunk/src/java/org/apache/log4j/spi/LocationInfo.java (original)
> +++ logging/log4j/trunk/src/java/org/apache/log4j/spi/LocationInfo.java Thu Aug 31 21:50:45
2006
> @@ -42,7 +42,7 @@
>     * without real location info available.
>     * @since 1.3
>     */
> -  public static LocationInfo NA_LOCATION_INFO = new LocationInfo(NA, NA, NA, NA);
> +  public static final LocationInfo NA_LOCATION_INFO = new LocationInfo(NA, NA, NA, NA);
>   
>  
>    
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message