logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51048] New: AsyncAppender.doAppend() does not to be synchronized
Date Mon, 11 Apr 2011 11:38:03 GMT

           Summary: AsyncAppender.doAppend() does not to be synchronized
           Product: Log4j
           Version: 1.2
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Appender
        AssignedTo: log4j-dev@logging.apache.org
        ReportedBy: kowalewski.bartosz@gmail.com

The AppenderSkeleton class defines the 'public synchronized void
doAppend(LoggingEvent event)' method. Making this method non synchronized
directly in AppenderSkeleton isn't safe as there are might be plenty of (custom
3rd party) subclasses that might take advantage of this synchronization. 

However, some widely used _concrete_ appenders that are defined inside the
log4j library could be optimized. The AsyncAppender class seems to be the most
often used appender in enterprise class systems. Making the doAppend() method
non synchronized in this case makes a lot of sense as checking if level is
lower than threshold is done in doAppend(). This change would improve log4j
behavior in multi-threaded environments.

AsyncAppender is anyway internally synchronized - it synchronizes on the buffer

Attaching a subclass of AsyncAppender that removes the unnecessary
'synchronized' keyword.

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

View raw message