logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralph Goers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-246) UDP socket Appender error
Date Wed, 29 May 2013 14:05:20 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669267#comment-13669267
] 

Ralph Goers commented on LOG4J2-246:
------------------------------------

Are we looking at the same code? AbstractAppender.error(String, LogEvent, Throwable) and AbstractAppender.error(String,
Throwable) are not the same and the LogEvent parameter is not unused. They call different
ErrorHandler methods - one takes the LogEvent and one does not. It just so happens that both
those methods perform the same action but they aren't required to.
                
> UDP socket Appender error
> -------------------------
>
>                 Key: LOG4J2-246
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-246
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Appenders, Core
>    Affects Versions: 2.0-beta5
>            Reporter: Remko Popma
>             Fix For: 2.0-beta7
>
>
> On 2013/05/09, at 18:34, Tomek Kaczynski <tomek.kaczynski@gmail.com> wrote:
> Hi All,
>    I'm using log4j2 since beta4, now beta5. In general it's a cute library, but there's
some bug that I've found out recently :
>    When a client code genreates a huge message ( 64k ), the underlying DatagramOutputStream
fails ( UDP socket throws exception).
>   After that all following flushes fail because data buffer is not cleared upon exception.
>  So in lines
> DatagramOutputStream:91
> ----------------------------------------------------------------------
>     public synchronized void flush() throws IOException {
>         if (this.data != null && this.ds != null && this.address != null)
{
>             final DatagramPacket packet = new DatagramPacket(data, data.length, address,
port);
>             ds.send(packet);
>         }
>         data = null;
>     }
> --------------------------------------------------------------------------
>    
> data = null should be put in finally block or some simillar solution could be applied.
> What do you think ?
> Regards,
> Tomek
> Moreover DatagramOutputStream should check if message size is less then 64k .

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message