logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jeremy franklin-ross (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-299) Ability to retrieve original Throwable from ThrowableProxy
Date Tue, 02 Jul 2013 17:01:23 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697974#comment-13697974
] 

jeremy franklin-ross commented on LOG4J2-299:
---------------------------------------------

Gary, That doesn't read true... It appears that we set our suppressed Throwable to a new ThrowableProxy,
rather than the original throwable. Perhaps this is a bug? Line 528 below.

523        private void setSuppressed(final Throwable throwable) {
524            if (getSuppressed != null && addSuppressed != null) {
525                try {
526                    final Throwable[] array = (Throwable[]) getSuppressed.invoke(throwable);
527                    for (final Throwable t : array) {
528                        addSuppressed.invoke(this, new ThrowableProxy(t));
529                    }
530                } catch (final Exception ignore) {
531                    //
532                }
533            }
534        }


                
> Ability to retrieve original Throwable from ThrowableProxy
> ----------------------------------------------------------
>
>                 Key: LOG4J2-299
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-299
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0-beta7
>            Reporter: jeremy franklin-ross
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> If ThrowableProxy is to exist without change, it would be polite to provide mechanism
to retrieve the initial source Throwable in an unadulterated form. 
> As already reported it's impossible to retrieve the original class name of the Throwable
that was the source of a proxy instance, though the data exists as the private name attribute,
which wouldn't be an issue at all if we could merely access the 
> Say via something like:
> public Throwable proxiedThrown()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message