lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject [lucenenet] 01/02: Lucene.Net.Benchmark: Disabled non strong named warning for SharpZipLib.NETStandard (unsupported 3rd party clone) for .NET Standard 1.6. Chances are slim anyone will want to use this library on that platform - even slimmer that they will be using strong naming.
Date Thu, 08 Aug 2019 11:57:27 GMT
This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git

commit 6b02ec4198912f6b34f92bd3230280870e404a78
Author: Shad Storhaug <shad@shadstorhaug.com>
AuthorDate: Thu Aug 8 18:52:16 2019 +0700

    Lucene.Net.Benchmark: Disabled non strong named warning for SharpZipLib.NETStandard (unsupported
3rd party clone) for .NET Standard 1.6. Chances are slim anyone will want to use this library
on that platform - even slimmer that they will be using strong naming.
---
 src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj b/src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj
index f1d5b73..7b19cfd 100644
--- a/src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj
+++ b/src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj
@@ -71,6 +71,12 @@
   </ItemGroup>
 
   <PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.6' ">
+    <!-- SharpZipLib.NETStandard is not strong named - we don't really care.
+        Odds are very slim we will have any downloaders of the benchmark library on this
+        platform and even slimmer that they will require strong naming. 
+        We would just drop support for .NET Standard 1.6 for this library if
+        it didn't mean adding a special case to the build/tests. -->
+    <NoWarn>$(NoWarn);8002</NoWarn>
     <DebugType>portable</DebugType>
   </PropertyGroup>
 


Mime
View raw message