maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shane StClair (JIRA)" <j...@codehaus.org>
Subject [jira] (MSHADE-111) minimizeJar should not remove classes specifically included by filters
Date Sat, 10 Mar 2012 05:36:02 GMT

    [ https://jira.codehaus.org/browse/MSHADE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=293766#comment-293766
] 

Shane StClair commented on MSHADE-111:
--------------------------------------

Actually this patch isn't quite complete, as filter include patterns affect classes outside
of the specified artifact (<include>**</include> on any filter will currently
prevent any classes from being removed).
                
> minimizeJar should not remove classes specifically included by filters
> ----------------------------------------------------------------------
>
>                 Key: MSHADE-111
>                 URL: https://jira.codehaus.org/browse/MSHADE-111
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 1.5
>            Reporter: Shane StClair
>         Attachments: mshade-111-fixed.patch, mshade-111.patch
>
>
> Currently there is no way to specify classes that should not be removed by minimizeJar.
This means that projects using dynamically loaded classes (log4j, for instance) cannot use
minimizeJar. This patch prevents minimizeJar from removing classes that were specified for
inclusion in a filter.
> The patch also fixes a test in ComponentsXmlResourceTransformerTest that was failing
on Windows due to different line breaks in a string comparison.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message