mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 65613: Fixed a bug where MockSlave `id` is not properly initialized.
Date Mon, 12 Feb 2018 19:32:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65613/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

The `MockSlave` did not initialize the id field using the input
argument. Also it is necessary to call its virtual base class
`ProcessBase` constructor explicitly to avoid argument `id` being
lost.


Diffs
-----

  src/tests/mock_slave.cpp 597d7abef20dd5f89b16e4616233f02760b9d037 


Diff: https://reviews.apache.org/r/65613/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message