mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <>
Subject Re: Review Request 59987: Added protobuf map support.
Date Mon, 26 Feb 2018 09:05:55 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 26, 2018, 5:05 p.m.)

Review request for mesos, Anand Mazumdar, Chun-Hung Hsiao, and Zhitao Li.


Addressed review comments.

Bugs: MESOS-7656

Repository: mesos


Map is a feature of proto2 syntax, but it can only be compiled
with proto3 compiler, see the following discussion for details:!topic/protobuf/p4WxcplrlA4
We have already upgraded the compiler from 2.6.1 to 3.3.0 in
MESOS-7228, however, to use protobuf map in Mesos code, we also
need to add the protobuf map support to the code in Mesos for
converting protobuf message to JSON object and parsing JSON
object as protobuf message, that is what I have done in this patch.

Diffs (updated)

  3rdparty/stout/include/stout/protobuf.hpp 4a1605e5130dbf7e8286dbb43d0d04ab4394e79a 





Qian Zhang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message