mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] asekretenko commented on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Date Mon, 17 May 2021 07:28:00 GMT

asekretenko commented on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842080959


   @cf-natali It would help readers if the commit message made it clear that the issue is
only triggered by recent linux headers (something in line of "Fixed compilation against linux
5.0+ capabilities.h" - I'm not sure which exact introduced them, please check that). Otherwise,
looks good to me. 
   
   Great that you caught this before releasing this code! Otherwise, this rename in `proto`s
would be potentially breaking users of json APIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message