mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] cf-natali commented on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Date Mon, 17 May 2021 07:41:51 GMT

cf-natali commented on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842091364


   > Great that you caught this before releasing this code! Otherwise, this rename in protos
would be potentially breaking users of json APIs (due to how our json deserialization uses
protobuf reflection).
   
   Yeah, although it was my fault in the first place, at the time I didn't have access to
such a recent kernel/libc, so couldn't properly test it.
   It'd help if we had more recent/varied buildbots.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message