mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] qianzhangxa edited a comment on pull request #384: Fixed parsing of ld.so.cache on new glibc.
Date Sat, 29 May 2021 13:25:01 GMT

qianzhangxa edited a comment on pull request #384:
URL: https://github.com/apache/mesos/pull/384#issuecomment-850833193


   > FWIW it's breaking other things:
   > 
   > ```
   > [ RUN      ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage
   > ../../src/tests/health_check_tests.cpp:505: Failure
   > (testImage).failure(): Failed to create docker test image rootfs: Failed to parse
ld.so cache: Invalid format
   > [  FAILED  ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage (26 ms)
   > ```
   
   @cf-natali Did you run this test in the same machine with the other tests (like `LdcacheTest.Parse`),
all of these tests will call `ldcache::parse()` internally, so it does not make sense that
one succeeds but the other fails.
   
   In another hand, there are a couple of places in `ldcache::parse()` which will error out
with `Invalid format`, maybe we should use distinct error message in each place so that we
can better troubleshooting this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message