mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] cf-natali commented on pull request #384: Fixed parsing of ld.so.cache on new glibc.
Date Sat, 29 May 2021 14:14:23 GMT

cf-natali commented on pull request #384:
URL: https://github.com/apache/mesos/pull/384#issuecomment-850840426


   On Sat, 29 May 2021, 14:24 Qian Zhang, ***@***.***> wrote:
   
   > FWIW it's breaking other things:
   >
   > [ RUN      ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage
   > ../../src/tests/health_check_tests.cpp:505: Failure
   > (testImage).failure(): Failed to create docker test image rootfs: Failed to parse
ld.so cache: Invalid format
   > [  FAILED  ] HealthCheckTest.ROOT_HealthyTaskWithContainerImage (26 ms)
   >
   > @cf-natali <https://github.com/cf-natali> Did you run this test in the
   > same machine with the other tests (like LdcacheTest.Parse), all of these
   > tests will call ldcache::parse() internally, so it does not make sense
   > that one succeeds but the other fails.
   >
   
   I'm not sure what you mean - this test is an example of failing tests,
   among many others.
   
   
   In another hand, there are a couple of places in ldcache::parse() which
   > will error out with Invalid format, maybe we should use distinct error
   > message in each places so that we can better troubleshooting this issue.
   >
   
   Dunno, the issue seems pretty clear to me, it affects anything parsing
   ldcache due to the format change. And the attached change fixes it.
   
   
   
   —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/mesos/pull/384#issuecomment-850833193>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AB75O43IY5HF3SVBGXFFSS3TQDTIZANCNFSM443EOPDA>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message