myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lof...@apache.org
Subject svn commit: r910196 - /myfaces/tobago/trunk/tobago-jsf-compat/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java
Date Mon, 15 Feb 2010 10:47:54 GMT
Author: lofwyr
Date: Mon Feb 15 10:47:53 2010
New Revision: 910196

URL: http://svn.apache.org/viewvc?rev=910196&view=rev
Log:
TOBAGO-810: OnComponentCreated
  super.doStartTag() must be called before using the component, because of initilization.

Modified:
    myfaces/tobago/trunk/tobago-jsf-compat/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java

Modified: myfaces/tobago/trunk/tobago-jsf-compat/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-jsf-compat/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java?rev=910196&r1=910195&r2=910196&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-jsf-compat/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java
(original)
+++ myfaces/tobago/trunk/tobago-jsf-compat/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java
Mon Feb 15 10:47:53 2010
@@ -18,8 +18,6 @@
  */
 
 import org.apache.commons.lang.StringUtils;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
 import org.apache.myfaces.tobago.component.OnComponentCreated;
 import org.apache.myfaces.tobago.component.OnComponentPopulated;
 
@@ -30,17 +28,16 @@
 
 public abstract class TobagoELTag extends UIComponentELTag {
 
-  private static final Log LOG = LogFactory.getLog(TobagoELTag.class);
- 
   @Override
   public int doStartTag() throws JspException {
+    int result = super.doStartTag();
     UIComponent component = getComponentInstance();
     if (component instanceof OnComponentCreated
         && component.getAttributes().get(OnComponentCreated.MARKER) == null) {
       component.getAttributes().put(OnComponentCreated.MARKER, Boolean.TRUE);
       ((OnComponentCreated) component).onComponentCreated(getFacesContext());
     }
-    return super.doStartTag();
+    return result;
   }
 
   @Override



Mime
View raw message