nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2500) Add pull-reqest template to github
Date Thu, 24 May 2018 12:28:00 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488890#comment-16488890
] 

ASF GitHub Bot commented on NUTCH-2500:
---------------------------------------

sebastian-nagel closed pull request #333: NUTCH-2500 Add pull-reqest template for github
URL: https://github.com/apache/nutch/pull/333
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 000000000..e549eb0e3
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,13 @@
+Thanks for your contribution to [Apache Nutch](http://nutch.apache.org/)! Your help is appreciated!
+
+Before opening the pull request, please verify that
+* there is an open issue on the [Nutch issue tracker](https://issues.apache.org/jira/projects/NUTCH)
which describes the problem or the improvement. We cannot accept pull requests without an
issue because the change wouldn't be listed in the release notes.
+* the issue ID (`NUTCH-XXXX`)
+  - is referenced in the title of the pull request
+  - and placed in front of your commit messages
+* commits are squashed into a single one (or few commits for larger changes)
+* Java source code follows [Nutch Eclipse Code Formatting rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
+* Nutch is successfully built and unit tests pass by running `ant clean runtime test`
+* there should be no conflicts when merging the pull request branch into the *recent* master
branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly
pulled master branch.
+
+We will be able to faster integrate your pull request if these conditions are met. If you
have any questions how to fix your problem or about using Nutch in general, please sign up
for the [Nutch mailing list](http://nutch.apache.org/mailing_lists.html). Thanks!


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add pull-reqest template to github
> ----------------------------------
>
>                 Key: NUTCH-2500
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2500
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Sebastian Nagel
>            Priority: Minor
>
> Github allows to add [pull request templates](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/).
For contributors already familiar with github from other projects that's probably the best
place to show a check list which helps us to get pull requests merged more quickly. Here's
a draft:
> {noformat}
> Thanks for your contribution to [Apache Nutch](http://nutch.apache.org/)! Your help is
appreciated!
> Before opening the pull request, please verify that
> * there is an open issue on the [Nutch issue tracker](https://issues.apache.org/jira/projects/NUTCH)
which describes the problem or the improvement. We cannot accept pull requests without an
issue because the change wouldn't be listed in the release notes.
> * the issue ID (`NUTCH-XXXX`)
>   - is referenced in the title of the pull request
>   - and placed in front of your commit messages
> * commits are squashed into a single one (or few commits for larger changes)
> * Java source code follows [Nutch Eclipse Code Formatting rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
> * Nutch builds and unit tests pass by running `ant clean runtime test`
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message