openoffice-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From truck...@apache.org
Subject [openoffice] branch AOO42X updated: Comment out an unused method that breaks compilation with gcc9.
Date Wed, 06 Nov 2019 06:38:40 GMT
This is an automated email from the ASF dual-hosted git repository.

truckman pushed a commit to branch AOO42X
in repository https://gitbox.apache.org/repos/asf/openoffice.git


The following commit(s) were added to refs/heads/AOO42X by this push:
     new 3a35560  Comment out an unused method that breaks compilation with gcc9.
3a35560 is described below

commit 3a355608af195ad43bccaef8eec06363d9718887
Author: Don Lewis <truckman@apache.org>
AuthorDate: Tue Nov 5 22:45:27 2019 -0800

    Comment out an unused method that breaks compilation with gcc9.
    
    In case someone needs this method in the future, leave behind a note
    with the likely code fix.
---
 main/basebmp/inc/basebmp/packedpixeliterator.hxx | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/main/basebmp/inc/basebmp/packedpixeliterator.hxx b/main/basebmp/inc/basebmp/packedpixeliterator.hxx
index 58a119f..038f2c3 100644
--- a/main/basebmp/inc/basebmp/packedpixeliterator.hxx
+++ b/main/basebmp/inc/basebmp/packedpixeliterator.hxx
@@ -606,14 +606,17 @@ public:
                 >> get_shift<num_intraword_positions, bits_per_pixel, MsbFirst>(remainder));

     }
 
+/***** XXX - This appears to be unused and fails to compile with gcc9
     value_type get(difference_type const & d) const
     {
+//      XXX - should x(d.x) be (x + d.x)?
         const int remainder( x(d.x) % num_intraword_positions );
 
         return (unsigned_cast<value_type>(*current(d.x,d.y) & 
                                           get_mask<value_type, bits_per_pixel, MsbFirst>(remainder))
                 >> get_shift<num_intraword_positions, bits_per_pixel, MsbFirst>(remainder));

     }
+******/
 
     void set( value_type v ) const
     {


Mime
View raw message