pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Brown <gkbr...@mac.com>
Subject Re: Little things (by FindBugs)
Date Tue, 01 Dec 2009 15:57:12 GMT
> Hi, with the help on FindBugs I found some little things to fix:
> 
> - LabelSkin.java:184 Dead store to textHeight
>       float textHeight = lm.getHeight();

Fixed.

> - TerraTextInputSkin.java:206 integral value cast to double and then
> passed to Math.ceil

Fixed.

> - Comparator implements Comparator but not Serializable (sorry, maybe
> some of them could be already in a previous warning)

These can be ignored.

> - BrowserApplicationContext.java:40 Class
> org.apache.pivot.wtk.BrowserApplicationContext$HostApplet defines
> non-transient non-serializable instance field applicationContext

Fixed.

> - 16 warnings on this type: TerraPaletteSkin.java:361 integral
> division result cast to double or float
> With a little change like this we can solve the warning:
> original (current):
>       graphics.setPaint(new GradientPaint(width / 2, 0, titleBarBevelColor,
>           width / 2, titleBarHeight + 1, titleBarBackgroundColor));
> modified:
>       graphics.setPaint(new GradientPaint(width / 2f, 0f, titleBarBevelColor,
>           width / 2f, titleBarHeight + 1, titleBarBackgroundColor));

Are all the warnings related to GradientPaint constructors? If so, feel free to fix them (you
may not need the "f" on the 0 - the "2f"s might be sufficient).

> - ValueSeries.java:1 org.apache.pivot.charts.content.ValueSeries
> doesn't override org.apache.pivot.collections.ArrayList.equals(Object)
> TreeView.java:633 org.apache.pivot.wtk.TreeView$BranchHandler doesn't
> override org.apache.pivot.collections.ArrayList.equals(Object)

These can be ignored.


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message