pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Whitcomb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIVOT-935) Allow styling of alerts without needing to globally amend theme colors
Date Thu, 20 Feb 2014 16:25:21 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907141#comment-13907141
] 

Roger Whitcomb commented on PIVOT-935:
--------------------------------------

Thanks, Oli.  Looks good, but could we do two things?
* Change the names to just "borderBackgroundColor" and "borderColor" (i.e., leave off the
"message" prefix) so the names are a little less verbose.
* Add the overall background color as well (as "backgroundColor"), so all the colors are settable
as styles?

Thanks.

> Allow styling of alerts without needing to globally amend theme colors
> ----------------------------------------------------------------------
>
>                 Key: PIVOT-935
>                 URL: https://issues.apache.org/jira/browse/PIVOT-935
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk-terra
>    Affects Versions: 2.1
>         Environment: Any
>            Reporter: Oliver Oyston
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: RestyledAlert.png, patch.diff
>
>
> For our custom application we would like more control over the look and feel of the pivot
alerts.
> Currently, to change the alert border colors you must globally change the Pivot theme
colors - this has knock on effects to other Pivot UI.
> It would be useful, as a minimum, if the alert message border color / background colors
are exposed. This would allow us to override the default colors globally for our application.
> I have made the required changes to trunk and will submit a proposed patch.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message