pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Lee Whitcomb (Jira)" <j...@apache.org>
Subject [jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
Date Thu, 14 May 2020 03:25:00 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106838#comment-17106838

Roger Lee Whitcomb commented on PIVOT-1032:

Fix [MethodLength] in TextAreaSkin to see if it could be done reasonably, and it was. Add
a method to TextArea and use it in the skin. Add comments to the other file.
Sending        wtk/src/org/apache/pivot/wtk/ClipboardContentListener.java
Sending        wtk/src/org/apache/pivot/wtk/TextArea.java
Sending        wtk/src/org/apache/pivot/wtk/skin/TextAreaSkin.java
Transmitting file data ...done
Committing transaction...
Committed revision 1877713.

> Implement "checkstyle" for builds and make changes to bring code into better compliance
> ---------------------------------------------------------------------------------------
>                 Key: PIVOT-1032
>                 URL: https://issues.apache.org/jira/browse/PIVOT-1032
>             Project: Pivot
>          Issue Type: Improvement
>            Reporter: Roger Lee Whitcomb
>            Assignee: Roger Lee Whitcomb
>            Priority: Minor
>         Attachments: 1032.diffs.txt
> I thought it would be interesting, in addition to the "trim-whitespace" task already
implemented, to do some sort of "checkstyle" processing to evaluate all the code to see where
there might be changes to make the code more robust and a better example of "canonical" Java
> I hesitate to expect that we could address everything (or indeed whether we *should*),
but there might be things that would make the code better and easier to read and maintain,
and wouldn't take much effort.

This message was sent by Atlassian Jira

View raw message