pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Lee Whitcomb (Jira)" <j...@apache.org>
Subject [jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
Date Fri, 30 Apr 2021 21:54:00 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337645#comment-17337645

Roger Lee Whitcomb commented on PIVOT-1032:

PIVOT-1032: Fix as many of the "checkstyle" problems in these files as possible.

Sending        charts/src/org/apache/pivot/charts/content/Interval.java
Sending        charts/src/org/apache/pivot/charts/content/Point.java
Sending        core/src/org/apache/pivot/collections/EnumList.java
Sending        core/src/org/apache/pivot/collections/concurrent/SynchronizedSet.java
Sending        core/src/org/apache/pivot/functional/monad/TryCompanion.java
Sending        core/src/org/apache/pivot/util/StringUtils.java
Sending        core/test/org/apache/pivot/util/test/ImmutableIteratorTest.java
Sending        core/test/org/apache/pivot/util/test/MIMETypeTest.java
Sending        core/test/org/apache/pivot/util/test/StringUtilsTest.java
Sending        core/test/org/apache/pivot/util/test/VoteResultTest.java
Sending        wtk/src/org/apache/pivot/wtk/effects/Transition.java
Sending        wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
Sending        wtk/src/org/apache/pivot/wtk/skin/DisplaySkin.java
Transmitting file data .............done
Committing transaction...
Committed revision 1889343.

> Implement "checkstyle" for builds and make changes to bring code into better compliance
> ---------------------------------------------------------------------------------------
>                 Key: PIVOT-1032
>                 URL: https://issues.apache.org/jira/browse/PIVOT-1032
>             Project: Pivot
>          Issue Type: Improvement
>            Reporter: Roger Lee Whitcomb
>            Assignee: Roger Lee Whitcomb
>            Priority: Minor
>             Fix For: 2.1.0
>         Attachments: 1032.diffs.txt
> I thought it would be interesting, in addition to the "trim-whitespace" task already
implemented, to do some sort of "checkstyle" processing to evaluate all the code to see where
there might be changes to make the code more robust and a better example of "canonical" Java
> I hesitate to expect that we could address everything (or indeed whether we *should*),
but there might be things that would make the code better and easier to read and maintain,
and wouldn't take much effort.

This message was sent by Atlassian Jira

View raw message