plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject decodeData in Plc4xS7Protocol
Date Thu, 28 Dec 2017 00:55:17 GMT
Hi,

Looking at decodeData in Plc4XS7Protocol I’m not sure that it would work in that the for
loop is increasing “i" but “i" is also modified in the body of the loop by the size of
the datatype. Seems by a casual glance that each datatype is one byte too large?

Also any reason why all the methods are private? Makes it a little harder to unit test. What
the preferred way of writing unit test for something list this?

Thanks,
Justin
Mime
View raw message