plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christofer Dutz <christofer.d...@c-ware.de>
Subject Re: decodeData in Plc4xS7Protocol
Date Fri, 29 Dec 2017 15:00:54 GMT
Hi Justin,

I did have a look at the code you referred to and I agree that this is actually not 100% correct.
It will probably not have caused any damage as each of the arrays is just one element. But
you are right it’s not correct. I fixed that … thanks for finding things like that ;-)

Chris

Am 28.12.17, 01:55 schrieb "Justin Mclean" <justin@classsoftware.com>:

    Hi,
    
    Looking at decodeData in Plc4XS7Protocol I’m not sure that it would work in that the
for loop is increasing “i" but “i" is also modified in the body of the loop by the size
of the datatype. Seems by a casual glance that each datatype is one byte too large?
    
    Also any reason why all the methods are private? Makes it a little harder to unit test.
What the preferred way of writing unit test for something list this?
    
    Thanks,
    Justin

Mime
View raw message