plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Feinauer <j.feina...@pragmaticminds.de>
Subject Re: Merged API Changes
Date Mon, 17 Sep 2018 09:32:50 GMT
Hey Chris,

it's not that specific tot he parser or ist implementation, it's more about the general question
how to handle a "bad" input from a user.
I openend a discussion thread for this change, as it seems a bit controversial : )

Julian

´╗┐Am 17.09.18, 11:27 schrieb "Christofer Dutz" <christofer.dutz@c-ware.de>:

    Hi Julian,
    
    yeah ... the Field parser ... it's a lot more complex now, but I didn't put that much
effort into it as you wanted to implement the Antlr4 parser __
    I thought it was a waste of time to fine-tune something that was going to be replaced
anyway ..
    
    Will have a look and merge asap.
    
    Chris
    
    
    
    Am 17.09.18, 10:31 schrieb "Julian Feinauer" <j.feinauer@pragmaticminds.de>:
    
        Hi Chris,
        
        thanks for the merge, the new api looks way better than the old one.
        I already updated my OPM branch to the new API and one thing I noticed is that we
did no longer throw a Checked Exception on wront user input (Query String).
        Thus I opened a PR (https://github.com/apache/incubator-plc4x/pull/21) where I made
the PlcInvalidFieldException checked (as the previous one, IllegalAdress or something was)
and added also an UncheckedInvalidFieldExeption (similar than UncheckedIOException in Java
8) to enable smooth usage in Lambdas.
        
        Then I refactored all places where Fields are parsed and added the checked Exception.
        
        I hope that everyone agrees with the change but I think we should notify users at
places where their input can lead to exceptions to force handling.
        
        Best
        Julian
        
        Am 17.09.18, 09:19 schrieb "Christofer Dutz" <christofer.dutz@c-ware.de>:
        
            Hi all,
            
            I just wanted to tell you that I just merged the API refactoring branch back to
master ... so now the API changes are live.
            
            Chris
            
        
        
    
    

Mime
View raw message