plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [plc4x] chrisdutz commented on pull request #178: Fix ToAnsi method : bufferoverflow
Date Tue, 01 Sep 2020 15:02:37 GMT

chrisdutz commented on pull request #178:

   Hi Johanna, 
   sorry for me picking this up so late ... I just had a look ... your code changes generally
look good, and I'm not going to insist on tests as in that case I would have to reject most
of my stuff to ;-)
   Does the driver work with your changes? Are you able to read with multiple "." in them?
I'm asking this stupid questions as I don't know the protocol and want to understand if this
just makes the Execption go away.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message