qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: QPID-3280: When sending a large number of messages with nonzero TTLs to a cluster, overall message throughput drops by around 20-30% compared to messages with TTL 0.
Date Thu, 26 May 2011 20:53:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/791/
-----------------------------------------------------------

(Updated 2011-05-26 20:53:00.027175)


Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim.


Summary (updated)
-------

QPID-3280: When sending a large number of messages with nonzero TTLs to a cluster, overall
message throughput drops by around 20-30% compared to messages with TTL 0.

Replaced the complicated message expirly logic in the cluster with a simpler "cluster clock"
for expiry of messages with TTL.

Patch supplied by Andy Goldstein <agoldste@redhat.com>.


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1128002 
  /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.h 1128002 
  /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.cpp 1128002 
  /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1128002 
  /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.h 1128002 
  /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.cpp 1128002 
  /trunk/qpid/cpp/src/qpid/cluster/Cluster.h 1128002 
  /trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp 1128002 
  /trunk/qpid/cpp/src/qpid/cluster/ClusterPlugin.cpp 1128002 
  /trunk/qpid/cpp/src/qpid/cluster/ClusterSettings.h 1128002 
  /trunk/qpid/cpp/src/qpid/cluster/Connection.h 1128002 
  /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1128002 
  /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.h 1128002 
  /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.cpp 1128002 
  /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1128002 
  /trunk/qpid/cpp/src/qpid/sys/Timer.h 1128002 
  /trunk/qpid/cpp/src/qpid/sys/Timer.cpp 1128002 
  /trunk/qpid/cpp/xml/cluster.xml 1128002 
  /trunk/qpid/python/examples/api/spout 1128002 

Diff: https://reviews.apache.org/r/791/diff


Testing
-------


Thanks,

Alan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message