qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (QPIDJMS-373) Support for OAuth flow and setting of "Authorization" Header for WS upgrade request
Date Wed, 04 Apr 2018 18:37:00 GMT

    [ https://issues.apache.org/jira/browse/QPIDJMS-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425990#comment-16425990
] 

Rob Godfrey edited comment on QPIDJMS-373 at 4/4/18 6:36 PM:
-------------------------------------------------------------

Is there an advantage to doing this as a new transport rather than writing a ConnectionFactory
or something, whereby the connection factory does the work to obtain the OAUTH credentials
before then calling the underlying factory and setting the auth header on the ws transport


was (Author: rgodfrey):
Is there an advantage to doing this as a new transport rather than writing a ConnectionFactory
or something, whereby the connection factory does the work to obtain the OAUTH credentials
before then calling the underlying factory and setting the auth header on the ws transport`/

> Support for OAuth flow and setting of "Authorization" Header for WS upgrade request
> -----------------------------------------------------------------------------------
>
>                 Key: QPIDJMS-373
>                 URL: https://issues.apache.org/jira/browse/QPIDJMS-373
>             Project: Qpid JMS
>          Issue Type: New Feature
>          Components: qpid-jms-client
>            Reporter: Michael Bolz
>            Priority: Major
>
> Add support for OAuth flow ("client_credentials" and "password") and setting of "Authorization"
Header during WebSocket connection handshake.
> Used "Authorization" Header or OAuth settings should/could be set via the "transport"
parameters (TransportOptions).
>  
> As PoC I created a [Fork|https://github.com/mibo/qpid-jms/tree/ws_add_header] and have
done one commit for the [add of the Authorization Header|https://github.com/mibo/qpid-jms/commit/711052f0891556db0da6e7d68908b2f9dafadede]
and one commit for the [OAuth flow|https://github.com/mibo/qpid-jms/commit/de70f0d3e4441358a239b3e776455201c133895d].
>  
> Hope this feature is not only interesting for me.
> If yes, I will add the currently missing tests to my contribution and do a pull request.
>  
> Regards, Michael



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message