qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (QPIDJMS-373) Support for OAuth flow and setting of "Authorization" Header for WS upgrade request
Date Thu, 05 Apr 2018 12:28:00 GMT

    [ https://issues.apache.org/jira/browse/QPIDJMS-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426828#comment-16426828
] 

Rob Godfrey edited comment on QPIDJMS-373 at 4/5/18 12:27 PM:
--------------------------------------------------------------

[~gemmellr] Registering a callback would be a nice general purpose enhancement I think; it
seems to me that this might be the only case where a user wants automatically invoke some
action prior to initiating the connection.  For example the issue being discussed here for
adding the oauth bearer token into a "header" prior to establishing the connection over WebSocket
could similarly apply to the case of making an XOAUTH2 TCP connection, where you want to inject
the token into the password of the connection to be returned.


was (Author: rgodfrey):
[~gemmellr] Registering a callback would be a nice general purpose enhancement I think; it
seems to me that this might be the only case where a user wants automatically invoke some
action prior to initiating the connection

> Support for OAuth flow and setting of "Authorization" Header for WS upgrade request
> -----------------------------------------------------------------------------------
>
>                 Key: QPIDJMS-373
>                 URL: https://issues.apache.org/jira/browse/QPIDJMS-373
>             Project: Qpid JMS
>          Issue Type: New Feature
>          Components: qpid-jms-client
>            Reporter: Michael Bolz
>            Priority: Major
>
> Add support for OAuth flow ("client_credentials" and "password") and setting of "Authorization"
Header during WebSocket connection handshake.
> Used "Authorization" Header or OAuth settings should/could be set via the "transport"
parameters (TransportOptions).
>  
> As PoC I created a [Fork|https://github.com/mibo/qpid-jms/tree/ws_add_header] and have
done one commit for the [add of the Authorization Header|https://github.com/mibo/qpid-jms/commit/711052f0891556db0da6e7d68908b2f9dafadede]
and one commit for the [OAuth flow|https://github.com/mibo/qpid-jms/commit/de70f0d3e4441358a239b3e776455201c133895d].
>  
> Hope this feature is not only interesting for me.
> If yes, I will add the currently missing tests to my contribution and do a pull request.
>  
> Regards, Michael



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message