qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Rudyy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-8245) [Broker-J] [AMQP 0-8..0-91] Decode FiledTable fields on demand
Date Fri, 28 Sep 2018 16:30:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632089#comment-16632089

Alex Rudyy commented on QPID-8245:

[~rgodfrey], I attached patch {{0007-QPID-8245-Change-decoding-to-decode-only-value-for-t.patch}}
implementing the idea described in your comment above. Could you please have a look in the

In my patch I re-used existing field {{_properties}}  to cache lazily decoded properties .
Your comments and the pseudo-code examples made me thinking that you considered elimination
of existing field {{_properties}} from the field table. Thus, FiledTable would only have QBB
and same caching map. Is it what you intended to do?

> [Broker-J] [AMQP 0-8..0-91] Decode FiledTable fields on demand
> --------------------------------------------------------------
>                 Key: QPID-8245
>                 URL: https://issues.apache.org/jira/browse/QPID-8245
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>    Affects Versions: qpid-java-broker-7.1.0
>            Reporter: Alex Rudyy
>            Priority: Major
>             Fix For: qpid-java-broker-7.1.0
>         Attachments: 0001-QPID-8245-Broker-J-Stop-rellocating-message-headers-.patch,
0002-QPID-8245-Add-factory-methods-to-create-field-table-.patch, 0003-QPID-8245-Remove-FiledTable-setters-methods-modifyin.patch,
0004-QPID-8245-Decode-field-table-properties-when-require.patch, 0005-QPID-8245-Remove-methods-getXXX-in-order-to-simplify.patch,
0005-QPID-8245-Split-field-table-into-2-implementations.patch, 0006-QPID-8245-some-code-clean-up.patch,
> At the moment all field table properties are decoded when decode functionality is invoked.
For use cases when only some of the field table properties are queried, the decoding functionality
can be changed to stop decoding on getting the requested property. Potentially, such approach
can improve the performance of routing transient messages when destinations are bound to the
routing exchange using selector filters. As filter expression contains only some properties,
the decoding of message headers can be stopped on getting all fields specified in selector
> The idea is illustrated by Rob Godfrey on [QPID-8238|https://issues.apache.org/jira/browse/QPID-8238?focusedCommentId=16601936&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16601936]

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message