ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Madhan Neethiraj" <mad...@apache.org>
Subject Re: Review Request 36961: RANGER-584: Service validation: Provide user friendly error messages about validation failures
Date Fri, 31 Jul 2015 20:30:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36961/#review93772
-----------------------------------------------------------



agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java (line
29)
<https://reviews.apache.org/r/36961/#comment148182>

    Please remove the author details - to be compliant with Apache requirements.



agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java (line
29)
<https://reviews.apache.org/r/36961/#comment148183>

    Please remove the author details - to be compliant with Apache requirements.


- Madhan Neethiraj


On July 31, 2015, 12:11 a.m., Alok Lal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36961/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 12:11 a.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-584
>     https://issues.apache.org/jira/browse/RANGER-584
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Service validation: Provide user friendly error messages about validation failures
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java
PRE-CREATION 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java
615e385 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationErrorCode.java
PRE-CREATION 
>   agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java
PRE-CREATION 
>   agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestValidationErrorCode.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36961/diff/
> 
> 
> Testing
> -------
> 
> new tests, existing tests
> 
> 
> Thanks,
> 
> Alok Lal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message