ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "dilli dorai" <dillido...@apache.org>
Subject Re: Review Request 39900: RANGER-716: New Public API to get server version info
Date Thu, 05 Nov 2015 14:30:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39900/#review105241
-----------------------------------------------------------



security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java (line 27)
<https://reviews.apache.org/r/39900/#comment163766>

    Comment applicable at the whole review level, not specific to this line or file.
    
    Summary and description do not match.
    Please correct them.


- dilli dorai


On Nov. 5, 2015, 10:26 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39900/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 10:26 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj,
Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-716
>     https://issues.apache.org/jira/browse/RANGER-716
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added a new REST API call to check validity of User credentials
> 
> 1) Should return - "statusCode":401,"msgDesc":"Authentication Failed" if user credentials
doesn't match 
> 2) Should return - "statusCode":200,"msgDesc":"Authentication Success" if user credentials
matches
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 689e16596be4ccd3b58061af70943bcf7ec5f66d

>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 572323f495e1fe01d7f1aed3de59dcb2a9e39bcf

>   security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 488ba8ff08c5385eb7306254672592e2c09a3b68

>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java ae407f12fd1855b3150c46aa3ec7b04723275a8c

>   security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java
abf4db4783474a94ffe1f3a24de6aec577982c42 
>   security-admin/src/main/java/org/apache/ranger/view/RangerServerInfo.java PRE-CREATION

>   security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js 3d33d8678b3069dcdba5ff5536722dc3eaaa90d4

> 
> Diff: https://reviews.apache.org/r/39900/diff/
> 
> 
> Testing
> -------
> 
> Tested with local Ranger setup.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message