ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dilli Dorai <dilli.do...@gmail.com>
Subject Re: REST API code review
Date Thu, 05 Nov 2015 15:58:25 GMT
Selva,
Would like to do that and spend more time on Ranger.
However, limited by time constraints due to my commitments to my employer.
Would alert dev list if I notice anything that could be improved.
Thanks
Dilli

On Thu, Nov 5, 2015 at 7:33 AM, Selvamohan Neethiraj <sneethir@apache.org>
wrote:

> +1
>
> Definitely will make it easy to review code …
>
> Thanks for the suggestion Dilli,  Would you be able to update the Ranger
> Wiki with the good coding practices ?
>
> Thanks,
> Selva-
>
> From:  Dilli Dorai <dilli.dorai@gmail.com>
> Reply-To:  "dev@ranger.incubator.apache.org" <
> dev@ranger.incubator.apache.org>
> Date:  Thursday, November 5, 2015 at 10:26 AM
> To:  "dev@ranger.incubator.apache.org" <dev@ranger.incubator.apache.org>
> Subject:  REST API code review
>
> Rangers,
>
> Would like to suggest some good practice while submitting code review for
> REST API changes.
>
> Please include curl calls for success case and failure case and show the
> outputs in code review Testing Done section.
>
> This would make it clear what is being addressed and help to get better
> code review.
>
> Anyone supporting this suggestion?
>
> Thanks
> Dilli
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message