ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Madhan Neethiraj" <mad...@apache.org>
Subject Re: Review Request 40834: Ranger 754 : Ranger YARN Plugin lookup and test connection should support SPENGO enabled HTTP Authentication
Date Tue, 01 Dec 2015 20:15:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40834/#review108551
-----------------------------------------------------------



agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java (line
399)
<https://reviews.apache.org/r/40834/#comment168004>

    Review the parameter name "datasourceName"; perhaps "sectionName" is more appropriate.



agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java (line
402)
<https://reviews.apache.org/r/40834/#comment168006>

    add parameter names and values in the debug log; like:
    
    LOG.debug("==> HadoopConfigHolder.getProperties(datasourceName=" + datasourceName +
", property=" + property + ")");
    
    Similarly update the debug log on exit:
    
    LOG.debug("<== HadoopConfigHolder.getProperties(datasourceName=" + datasourceName +
", property=" + property + "): ret=" + ret);



agents-common/src/main/resources/service-defs/ranger-servicedef-yarn.json (line 110)
<https://reviews.apache.org/r/40834/#comment168007>

    Changing itemId of an existing configuration would not work. If an existing service had
"commonNameForCertificate" (itemId=4) set to some value, after this service-def update that
value will get assigned to "hadoop.security.authentication" (the new configuration that has
itemId=4).



plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java (line 61)
<https://reviews.apache.org/r/40834/#comment168008>

    Since yarnUrl/username/password are already present in "configs", should these be passed
as parameters to this constructor? It might be clearner for the constructor to retrieve the
values from "configs"


- Madhan Neethiraj


On Dec. 1, 2015, 7:04 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40834/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 7:04 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Abhay Kulkarni, Madhan Neethiraj, and Selvamohan
Neethiraj.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger 754 : Ranger YARN Plugin lookup and test connection should support SPENGO enabled
HTTP Authentication
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java
f95e10e 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-yarn.json ff1f39f 
>   plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java fc07760

>   plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnConnectionMgr.java
e2cc2ef 
>   plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java
95d29c0 
> 
> Diff: https://reviews.apache.org/r/40834/diff/
> 
> 
> Testing
> -------
> 
> Configure the hadoop for  http Authenticaton https://hadoop.apache.org/docs/r1.2.1/HttpAuthentication.html
> 
> Verify Ranger Yarn Service Test connection successful in the Ranger Admin UI
> Verify Ranger Yarn Service Lookup fetching the yarn resources in Ranger Admin UI
> Verify the same without HTTP authentication in a cluster.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message